Skip to content

Add specific tolerations to calico-typha pods #5819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Add specific tolerations to calico-typha pods #5819

merged 1 commit into from
Aug 13, 2025

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 13, 2025

What type of PR is this?
/kind flake

What this PR does / why we need it:

This is the same problem as #5703 but for calico-typha pods, with the same fix as #5704.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 13, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 13, 2025
@nojnhuh nojnhuh mentioned this pull request Aug 13, 2025
Merged
4 tasks
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

/hold to get a few runs of the test in

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.08%. Comparing base (578a274) to head (c22e904).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5819      +/-   ##
==========================================
+ Coverage   53.06%   53.08%   +0.01%     
==========================================
  Files         279      279              
  Lines       29678    29687       +9     
==========================================
+ Hits        15750    15759       +9     
  Misses      13112    13112              
  Partials      816      816

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 13, 2025 •
edited
Loading

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance-with-ci-artifacts c22e904 link false /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

#5686

/test pull-cluster-api-provider-azure-capi-e2e

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

/test pull-cluster-api-provider-azure-capi-e2e

1 similar comment
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Aug 13, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@jackfrancis
Copy link
Contributor

I've seen enough

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c52a4a48eefd0f972cdbe07ae58fe0091d01abc6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7b2418f into kubernetes-sigs:main Aug 13, 2025
29 of 30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Aug 13, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Aug 13, 2025
@nojnhuh nojnhuh deleted the typha-tolerations branch August 16, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

Assignees

@jackfrancis jackfrancis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@nojnhuh @k8s-ci-robot @jackfrancis